fix(c/driver_manager): look for correct init symbol name#3681
Merged
Conversation
- Add sanity assertions - Actually test this end-to-end - Populate lib_path properly so the right init symbol name gets calculated Closes apache#3680.
zeroshade
approved these changes
Nov 4, 2025
Member
zeroshade
left a comment
There was a problem hiding this comment.
I agree that we should refactor and slim this down when we have a chance.
amoeba
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMO, the control flow now is very convoluted because it intermixes searching and loading, which led to this regression since it's hard to tell if the return value is actually fully initialized. I'm still not sure all code paths are correct. I may try to factor searching/loading out separately.
Closes #3680.