feat(c/driver_manager): don't ignore invalid manifests#3399
Conversation
|
@amoeba how does this work for you? I think the one case that isn't handled, though, is if it finds a manifest, the manifest is valid, but the manifest doesn't contain a path for the current platform. |
|
Don't forget to update the version in the go codebase (precommit checks for it) and the original reason why I returned "NOT_FOUND" in this case was so that it would keep searching if it encountered an invalid manifest rather than error immediately. |
|
I figured, but I'm asking if silently ignoring invalid manifests is really the behavior we want. And yes, this PR is incomplete |
|
This is a bit unwieldy but I think it's better to just preserve all info even if it's a bit ugly: |
|
|
Also @zeroshade the go file consistency check has been broken for a while it appears so I fixed that too |
ccef136 to
592298a
Compare
|
welp I managed to guess the problem after all |
zeroshade
left a comment
There was a problem hiding this comment.
just the one nitpick, but everything looks great, thanks!
amoeba
left a comment
There was a problem hiding this comment.
+1
Tested interactively and this is working great. Thanks for figuring this out.
Fixes #3398.