docs: fix safari rendering in manifest_load.mmd diagram#3391
Merged
Conversation
Member
Author
|
Here's how this PR renders for me on Safari on light and dark mode. Note the faint lines in dark mode:
|
lidavidm
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rendering of the manifest_load.mmd diagram under Safari by re-generating the SVG using mmdc. The original SVG checked into git was generated by hand using a web tool (mermaidchart.org)) which has a rendering bug under Safari. The YAML frontmatter this PR removes is not supported by the mmdc cli (it's specific to mermaidchart.org) so removing it is also required for the makefile to run correctly anyway.
This PR is an overall improvement but has one downside: When using dark mode, the connector lines between graph nodes is slightly less bright. We might be able to fix this with custom CSS (via
mmdc --cssFile).Resolves #3292.