fix(go/adbc/driver/bigquery): fix parsing repeated records with nested fields#3240
Merged
Conversation
…d fields (apache#47) Co-authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in parsing repeated records with nested fields in the BigQuery ADBC driver. The fix removes special case handling for repeated records and instead applies a unified approach where any repeated field becomes a list type.
- Removes complex conditional logic for handling repeated record fields with single vs multiple nested fields
- Simplifies the code by applying list wrapping to all repeated fields uniformly after type construction
- Adds comprehensive test coverage for various combinations of repeated and non-repeated record fields
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go/adbc/driver/bigquery/connection.go | Refactors buildField function to fix repeated record parsing by removing special case logic and applying unified list wrapping |
| go/adbc/driver/bigquery/connection_test.go | Adds new test file with comprehensive test cases for buildField function covering various field type scenarios |
Comments suppressed due to low confidence (1)
go/adbc/driver/bigquery/connection.go:810
- [nitpick] The variable name 'nestedFieldSchema' is inconsistent with the original code style. Consider using 'nestedSchema' to maintain consistency with the existing codebase pattern.
for i, nestedFieldSchema := range schema.Schema {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.