fix(csharp/src/Drivers/Databricks): fix CloudFetchResultFetcher initial results processing logic#3097
Merged
Conversation
…al results processing logic
## Summary
- Fixed failing unit tests in CloudFetchResultFetcherTest by correcting the conditional logic for processing
initial results
- The fetcher now properly handles initial results regardless of the `HasDirectResults` flag state
## Problem
Two unit tests were failing:
- `InitialResults_ProcessesInitialResultsCorrectly`
- `InitialResults_WithMoreRows_ContinuesFetching`
The issue was in the condition that checks whether to process direct/initial results. The previous logic required
`_statement.HasDirectResults` to be true even when processing initial results passed to the constructor, which
prevented the initial results from being processed in test scenarios.
## Solution
Changed the conditional logic from:
```csharp
if (_statement.HasDirectResults &&
(_statement.DirectResults?.ResultSet?.Results?.ResultLinks?.Count > 0 ||
_initialResults?.Results?.ResultLinks?.Count > 0))
To:
if ((_statement.HasDirectResults && _statement.DirectResults?.ResultSet?.Results?.ResultLinks?.Count > 0) ||
_initialResults?.Results?.ResultLinks?.Count > 0)
This ensures that initial results are processed when provided, regardless of the HasDirectResults flag.
Test plan
- All 12 tests in CloudFetchResultFetcherTest pass
- No regression in other CloudFetch-related tests
- Verified the fetcher correctly processes both direct results and initial results scenarios
CurtHagenlocher
approved these changes
Jul 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HasDirectResultsflag stateProblem
Two unit tests were failing:
InitialResults_ProcessesInitialResultsCorrectlyInitialResults_WithMoreRows_ContinuesFetchingThe issue was in the condition that checks whether to process direct/initial results. The previous logic required
_statement.HasDirectResultsto be true even when processing initial results passed to the constructor, whichprevented the initial results from being processed in test scenarios.
Solution
Changed the conditional logic from: