feat(csharp/src/Drivers/Databricks): Primary Key and Foreign Key Metadata Optimization#2886
Merged
Merged
Conversation
CurtHagenlocher
requested changes
May 28, 2025
Contributor
CurtHagenlocher
left a comment
There was a problem hiding this comment.
Thanks! Please resolve the white space issue identified by the linker and see additional comment.
| new Field("TABLE_SCHEM", StringType.Default, true), | ||
| new Field("TABLE_NAME", StringType.Default, true), | ||
| new Field("COLUMN_NAME", StringType.Default, true), | ||
| new Field("KEQ_SEQ", Int32Type.Default, true), |
Contributor
There was a problem hiding this comment.
should this be "KEY_SEQ"? If so, it also needs to be changed on line 448.
Contributor
Author
There was a problem hiding this comment.
Nope this should be KEQ
Contributor
There was a problem hiding this comment.
So the primary key column is named KEQ_SEQ and the foreign key column is named KEY_SEQ? Weird.
Contributor
Author
There was a problem hiding this comment.
Yes...that is weird but that is what returned from thrift
CurtHagenlocher
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arrow ADBC: Primary Key and Foreign Key Metadata Optimization
Description
This PR adds support for optimizing Primary Key and Foreign Key metadata queries in the C# Databricks ADBC driver. It introduces a new connection parameter
adbc.databricks.enable_pk_fkthat allows users to control whether the driver should make PK/FK metadata calls to the server or return empty results for improved performance.Background
Primary Key and Foreign Key metadata queries can be expensive operations, particularly in Databricks environments where they may not be fully supported in certain catalogs. This implementation provides a way to optimize these operations by:
Proposed Changes
adbc.databricks.enable_pk_fkto control PK/FK metadata behavior (default: true)How is this tested?
Added unit tests that verify:
ShouldReturnEmptyPkFkResultmethod with various combinations of settingsThese tests ensure that the optimization works correctly while maintaining compatibility with client applications that expect consistent schema structures.