close
Skip to content

fix(csharp/src/Drivers/BigQuery): TIME should be Time64Type.Microsecond#2741

Merged
CurtHagenlocher merged 7 commits into
apache:mainfrom
davidhcoe:dev/time-parse-fix
May 6, 2025
Merged

fix(csharp/src/Drivers/BigQuery): TIME should be Time64Type.Microsecond#2741
CurtHagenlocher merged 7 commits into
apache:mainfrom
davidhcoe:dev/time-parse-fix

Conversation

@davidhcoe
Copy link
Copy Markdown
Contributor

@davidhcoe davidhcoe commented Apr 23, 2025 •
edited
Loading

@github-actions github-actions Bot added this to the ADBC Libraries 18 milestone Apr 23, 2025
@davidhcoe davidhcoe marked this pull request as draft April 23, 2025 17:18
@davidhcoe davidhcoe changed the title fix(csharp/src/Apache.Arrow.Adbc/Extensions): fix Time conversion fix(csharp/src/Drivers/BigQuery): TIME should be Time64Type.Microsecond May 6, 2025
@davidhcoe davidhcoe marked this pull request as ready for review May 6, 2025 14:08
CurtHagenlocher
CurtHagenlocher requested changes May 6, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@CurtHagenlocher CurtHagenlocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you make two small formatting changes?

Comment thread csharp/src/Apache.Arrow.Adbc/Extensions/IArrowArrayExtensions.cs Outdated
Comment thread csharp/src/Client/SchemaConverter.cs
row[SchemaTableColumn.NumericScale] = decimal32Type.Scale;
}
else if (f.DataType is Decimal128Type decimal64Type)
else if (f.DataType is Decimal64Type decimal64Type)
Copy link
Copy Markdown
Contributor

@CurtHagenlocher CurtHagenlocher Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

derp

Comment thread csharp/src/Apache.Arrow.Adbc/Extensions/IArrowArrayExtensions.cs Outdated
Comment thread csharp/test/Apache.Arrow.Adbc.Tests/IArrowArrayExtensionsTests.cs Outdated
CurtHagenlocher
CurtHagenlocher reviewed May 6, 2025
View reviewed changes
Comment thread csharp/test/Apache.Arrow.Adbc.Tests/IArrowArrayExtensionsTests.cs
CurtHagenlocher
CurtHagenlocher approved these changes May 6, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@CurtHagenlocher CurtHagenlocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@CurtHagenlocher CurtHagenlocher merged commit eee8bca into apache:main May 6, 2025
6 checks passed
@serramatutu serramatutu mentioned this pull request Aug 12, 2025
Closed
@davidhcoe davidhcoe deleted the dev/time-parse-fix branch October 24, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CurtHagenlocher CurtHagenlocher CurtHagenlocher approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

ADBC Libraries 19

Development

Successfully merging this pull request may close these issues.

C#/ADBC/driver/googlebigquery: The time type data cannot be read correctly

3 participants

@davidhcoe @CurtHagenlocher @lidavidm