feat(python/adbc_driver_manager): add cursor() arg to set options#2589
Merged
Conversation
- Add a keyword-only argument to set statement options directly when creating a cursor, which makes it a little clearer what's going on. - Allow using True and False directly as option values (they will get converted to ENABLED and DISABLED, respectively). - Add the `use_copy` option to the PostgreSQL options enum. - Add an example of this with PostgreSQL. Fixes apache#2093. Fixes apache#2146.
This was referenced Mar 10, 2025
Closed
zeroshade
approved these changes
Mar 10, 2025
Member
zeroshade
left a comment
There was a problem hiding this comment.
LGTM in general, though we should really fix the failing CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use_copyoption to the PostgreSQL options enum.Fixes #2093.
Fixes #2146.