Fix RichHandler surrogate logging on strict utf-8 streams#4095
Open
lwhelton wants to merge 1 commit intoTextualize:masterfrom
Open
Fix RichHandler surrogate logging on strict utf-8 streams#4095lwhelton wants to merge 1 commit intoTextualize:masterfrom
lwhelton wants to merge 1 commit intoTextualize:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of changes
AI?
AI generated PRs may be accepted, but only if @willmcgugan has responded on an issue or discussion.
Checklist
Description
Fixes a UnicodeEncodeError in RichHandler when logging messages contain surrogate characters and the target stream uses strict UTF-8 encoding. The handler now escapes unencodable messages before constructing the final Rich text object, which preserves logging output instead of crashing. A regression test was added to cover strict UTF-8 stream behavior.
Important: Link to an issue or discussion regarding these changes.