Fix ConsoleOptions propagation#4084
Conversation
alokshukla631
left a comment
There was a problem hiding this comment.
I think this is still incomplete on the highlight side.
Columns, Rule, Table, and Measurement.get() still call render_str(..., highlight=False), so console.print(..., highlight=True) appears to remain ignored for nested strings even after this patch. For example, on this branch:
from rich.console import Console
from rich.columns import Columns
console = Console(force_terminal=True, color_system="truecolor", _environ={})
console.print(Columns(["123"]), highlight=True)still emits plain 123, while console.print("123", highlight=True) highlights it.
Could we propagate options.highlight through these calls as well, and add coverage for that path alongside the new emoji / markup tests?
|
I honestly don't know the correct answer concerning For @willmcgugan Can you provide some insight into this? Are any of these four |
|
I took a quick look on current The part that still seems ambiguous to me is whether |
Type of changes
AI?
AI generated PRs may be accepted, but only if @willmcgugan has responded on an issue or discussion.
Checklist
Description
Fixes #4028
Added the
emojifield toConsoleOptions, allowingemojioverrides passed toconsole.print()to be propagated down the rendering stack.Fixed several instances (
Table,Rule,Columns, andMeasure) where the renderables were callingconsole.render_str()but failing to pass the some or all ofemoji,markup, andhighlightsettings from the activeConsoleOptions.