close
Skip to content

BREAKING CHANGE: feat: Support multiple segment#23

Merged
OUDON merged 7 commits intodevelopfrom
feat/multiple-segment
Aug 18, 2022
Merged

BREAKING CHANGE: feat: Support multiple segment#23
OUDON merged 7 commits intodevelopfrom
feat/multiple-segment

Conversation

@OUDON
Copy link
Copy Markdown
Owner

@OUDON OUDON commented Aug 18, 2022 •
edited
Loading

This PR includes BREAKING CHANGE.

Before

qr = rMQR(version, error_correction_level)
qr.make("123456", encoder_class=encoder.NumericEncoder)

After

qr = rMQR(version, error_correction_level)
qr.add_segment("123", encoder_class=encoder.NumericEncoder)
qr.add_segment("Abc", encoder_class=encoder.ByteEncoder)
qr.make()

@OUDON OUDON self-assigned this Aug 18, 2022
@OUDON OUDON changed the title feat: Support multiple segment BREAKING CHANGE: feat: Support multiple segment Aug 18, 2022
@OUDON OUDON marked this pull request as ready for review August 18, 2022 11:16
@OUDON OUDON added the enhancement New feature or request label Aug 18, 2022
@OUDON OUDON merged commit 4aa0f79 into develop Aug 18, 2022
@OUDON OUDON deleted the feat/multiple-segment branch August 18, 2022 22:15
@OUDON OUDON mentioned this pull request Aug 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@OUDON OUDON

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@OUDON