close
Skip to content

Fix content duplication in embedded-wallets/sdk/ios/advanced/dapp-share.mdx page#2868

Open
swastik7805 wants to merge 4 commits intoMetaMask:mainfrom
swastik7805:2859/dapp-share-content-fix
Open

Fix content duplication in embedded-wallets/sdk/ios/advanced/dapp-share.mdx page#2868
swastik7805 wants to merge 4 commits intoMetaMask:mainfrom
swastik7805:2859/dapp-share-content-fix

Conversation

@swastik7805
Copy link
Copy Markdown
Contributor

@swastik7805 swastik7805 commented Apr 17, 2026

Description

This PR resolves content duplication and verbosity issues in embedded-wallets/sdk/ios/advanced/dapp-share.mdx.

Key changes include:

  • Condensed infrastructure summary: Replaced the detailed 2-of-3 share explanation with a brief summary and a direct link to the canonical Infrastructure page.
  • Streamlined Mobile UX section: Reduced the background explanation to 2-3 focused sentences explaining why dapp shares are necessary on mobile (reliability of browser storage).
  • Removed redundant definitions: Deleted the repetitive Web3Auth issues a dapp share... sentence that appeared at the start of the Dapp share in iOS section, as it was already covered in the preceding paragraph.

Issue(s) fixed

Fixes #2859 proposed by @bgravenorst

Preview

The changes can be viewed in the embedded-wallets/sdk/ios/advanced/dapp-share.mdx file.

Before:

image

After:

image

Checklist

  • If this PR updates or adds documentation content that changes or adds technical meaning, it has received an approval from an engineer or DevRel from the relevant team.
  • If this PR updates or adds documentation content, it has received an approval from a technical writer.

External contributor checklist

  • I've read the contribution guidelines.
  • I've created a new issue (or assigned myself to an existing issue) describing what this PR addresses.

Note

Low Risk
Documentation-only edits that remove duplicated text and reword explanations; no runtime or API behavior changes.

Overview
Simplifies the dapp-share.mdx iOS documentation by removing duplicated/overly detailed explanations of key-share infrastructure and the mobile login flow.

Replaces the long 2-of-3 share breakdown with a short summary that links to the canonical Embedded Wallets infrastructure page, streamlines the Mobile platform user experience section to focus on browser-storage unreliability, and removes a redundant dapp-share definition from the iOS section.

Reviewed by Cursor Bugbot for commit 345d245. Bugbot is set up for automated code reviews on this repo. Configure here.

@swastik7805 swastik7805 requested review from a team as code owners April 17, 2026 15:07
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 17, 2026

@swastik7805 is attempting to deploy a commit to the Consensys Team on Vercel.

A member of the Team first needs to authorize it.

@swastik7805
Copy link
Copy Markdown
Contributor Author

@bgravenorst @alexandratran @AyushBherwani1998 @yashovardhan hey guys, i have fixed issue #2859 by optimising the content in embedded-wallets/sdk/ios/advanced/dapp-share.mdx removing redundancy and making sure DRY principle is followed.

PR is updated and ready for review.

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 21, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
metamask-docs Ready Ready Preview, Comment Apr 21, 2026 11:16pm

Request Review

@bgravenorst
Copy link
Copy Markdown
Contributor

Will revisit this after #2854 is merged.

@swastik7805
Copy link
Copy Markdown
Contributor Author

Will revisit this after #2854 is merged.

Okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consolidate duplicated infrastructure content in dapp-share.mdx

2 participants