Fix content duplication in embedded-wallets/sdk/ios/advanced/dapp-share.mdx page#2868
Open
swastik7805 wants to merge 4 commits intoMetaMask:mainfrom
Open
Fix content duplication in embedded-wallets/sdk/ios/advanced/dapp-share.mdx page#2868swastik7805 wants to merge 4 commits intoMetaMask:mainfrom
embedded-wallets/sdk/ios/advanced/dapp-share.mdx page#2868swastik7805 wants to merge 4 commits intoMetaMask:mainfrom
Conversation
|
@swastik7805 is attempting to deploy a commit to the Consensys Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
@bgravenorst @alexandratran @AyushBherwani1998 @yashovardhan hey guys, i have fixed issue #2859 by optimising the content in PR is updated and ready for review. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Will revisit this after #2854 is merged. |
Contributor
Author
Okay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves content duplication and verbosity issues in
embedded-wallets/sdk/ios/advanced/dapp-share.mdx.Key changes include:
(reliability of browser storage).Web3Auth issues a dapp share...sentence that appeared at the start of theDapp share in iOSsection, as it was already covered in the preceding paragraph.Issue(s) fixed
Fixes #2859 proposed by @bgravenorst
Preview
The changes can be viewed in the
embedded-wallets/sdk/ios/advanced/dapp-share.mdxfile.Before:
After:
Checklist
External contributor checklist
Note
Low Risk
Documentation-only edits that remove duplicated text and reword explanations; no runtime or API behavior changes.
Overview
Simplifies the
dapp-share.mdxiOS documentation by removing duplicated/overly detailed explanations of key-share infrastructure and the mobile login flow.Replaces the long 2-of-3 share breakdown with a short summary that links to the canonical Embedded Wallets infrastructure page, streamlines the Mobile platform user experience section to focus on browser-storage unreliability, and removes a redundant dapp-share definition from the iOS section.
Reviewed by Cursor Bugbot for commit 345d245. Bugbot is set up for automated code reviews on this repo. Configure here.