Make MetaMember::name 'a instead of 'static#295
Open
dubrowgn wants to merge 1 commit into
Open
Conversation
UntypedComponent::member() and friends take a MetaMember with a 'static name string. This string is then immediately copied into a c-string before use, so the 'static lifetime is not necessary. The name only needs to lives for the duration of the function call. Using 'static is fine for many cases, but makes makes generating arbitrary component members at runtime problematic. Given the nature of the API, this usecase is highly likely. Instead of using 'static name, use 'a instead, such that generating dynamic component members at runtime using dynamic string names is easily possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UntypedComponent::member() and friends take a MetaMember with a 'static name string. This string is then immediately copied into a c-string before use, so the 'static lifetime is not necessary. The name only needs to live for the duration of the function call.
Using 'static is fine for many cases, but makes generating arbitrary component members at runtime problematic. Given the nature of the API, this usecase is highly likely.
Instead of using 'static name, use 'a instead, such that generating dynamic component members at runtime using dynamic string names is easily possible.