fix: tooltip incorrectly lists volumes among Daily Cleanup targets#4328
Open
teoobarca wants to merge 1 commit intoDokploy:canaryfrom
Open
fix: tooltip incorrectly lists volumes among Daily Cleanup targets#4328teoobarca wants to merge 1 commit intoDokploy:canaryfrom
teoobarca wants to merge 1 commit intoDokploy:canaryfrom
Conversation
The Daily Docker Cleanup tooltip lists `volumes` among pruned resources, but `cleanupAll` in `packages/server/src/utils/docker/utils.ts` excludes the volume prune via `excludedCleanupAllCommands` (added in Dokploy#3267). Removes `volumes` from the tooltip to match actual behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Daily Docker Cleanup tooltip lists
volumesamong pruned resources, butcleanupAllinpackages/server/src/utils/docker/utils.tsexcludes the volume prune viaexcludedCleanupAllCommands(added in #3267).Removes
volumesfrom the tooltip to match actual behavior.Greptile Summary
Removes
volumesfrom the Daily Docker Cleanup tooltip to match the actual behavior ofcleanupAll, which explicitly skips volume pruning viaexcludedCleanupAllCommands(intentionally excluded since #3267 to prevent accidental data loss from stopped containers).Confidence Score: 5/5
Safe to merge — single-line tooltip copy fix with no logic changes.
The change is a one-line documentation/UI fix that correctly aligns tooltip text with verified server-side behavior. No logic, no risk.
No files require special attention.
Reviews (1): Last reviewed commit: "fix: tooltip incorrectly lists volumes a..." | Re-trigger Greptile