Fix AttributeError on closed IPCClient (#68993)#69026
Open
SAY-5 wants to merge 2 commits into
Open
Conversation
Contributor
|
|
Signed-off-by: SAY-5 <say.apm35@gmail.com>
34731e8 to
c31d42e
Compare
Author
|
Retargeted to 3006.x per @dwoz, the fix still applies (ipc.py exists; closed-state branch unchanged). Verified locally. |
Contributor
|
@SAY-5 This is a bug. what are the chances you can write a regression test? |
…ck#68993) Signed-off-by: SAY-5 <say.apm35@gmail.com>
Author
|
Added the regression test, thanks @dwoz! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #68993.
When
IPCClient.close()runs while_connect()is still pending, the coroutine reachesset_result/set_exceptionafter_connecting_futurehas been cleared toNone, raisingAttributeError. Guard both call sites with a None-check.