close
Skip to content

solarish: Add IP TTL and IPv6 Hop Limit consts#5089

Merged
JohnTitor merged 1 commit intorust-lang:mainfrom
taspelund:illumos_sockopt_expansion
May 6, 2026
Merged

solarish: Add IP TTL and IPv6 Hop Limit consts#5089
JohnTitor merged 1 commit intorust-lang:mainfrom
taspelund:illumos_sockopt_expansion

Conversation

@taspelund
Copy link
Copy Markdown
Contributor

@taspelund taspelund commented Apr 29, 2026

Adds:

  • IPV6_HOPLIMIT (illumos + solaris)
  • IPV6_MINHOPCOUNT (illumos)
  • IP_MINTTL (illumos)

Description

Adds const definitions for setsockopt macros IP_MINTTL, IPV6_HOPLIMIT and IPV6_MINHOPCOUNT.

Sources

https://code.illumos.org/plugins/gitiles/illumos-gate/+/refs/heads/master/usr/src/uts/common/netinet/in.h#939
https://code.illumos.org/plugins/gitiles/illumos-gate/+/refs/heads/master/usr/src/uts/common/netinet/in.h#1236
https://code.illumos.org/plugins/gitiles/illumos-gate/+/refs/heads/master/usr/src/uts/common/netinet/in.h#1309

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);

I attempted to run libc-test locally, but it fails to compile due to errors unrelated to this change (the test fails to build/run on main, without this commit). Build errors here.

@rustbot label +stable-nominated

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 29, 2026

Some changes occurred in a solarish module

cc @jclulow, @pfmooney

@rustbot rustbot added S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Apr 29, 2026
@taspelund taspelund force-pushed the illumos_sockopt_expansion branch 3 times, most recently from a1352c0 to 7bc8683 Compare April 29, 2026 02:30
Adds:
- IPV6_HOPLIMIT (illumos + solaris)
- IPV6_MINHOPCOUNT (illumos)
- IP_MINTTL (illumos)

Signed-off-by: Trey Aspelund <trey@oxidecomputer.com>
@taspelund taspelund force-pushed the illumos_sockopt_expansion branch from 7bc8683 to 1b33d39 Compare April 29, 2026 02:31
Copy link
Copy Markdown
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on my end, waiting for a review from target maintainers

View changes since this review

@JohnTitor JohnTitor added this pull request to the merge queue May 5, 2026
Merged via the queue into rust-lang:main with commit f8d641a May 6, 2026
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stable-nominated This PR should be considered for cherry-pick to libc's stable release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants