close
Skip to content

fix(newlib): update stat struct to match official headers#5061

Open
chengr4 wants to merge 1 commit intorust-lang:mainfrom
chengr4:newlib-stat
Open

fix(newlib): update stat struct to match official headers#5061
chengr4 wants to merge 1 commit intorust-lang:mainfrom
chengr4:newlib-stat

Conversation

@chengr4
Copy link
Copy Markdown

@chengr4 chengr4 commented Apr 16, 2026

Description

This PR fixes #2795

Note: If any platforms that meet the above criteria are added, they would need to create their own definition and use that (maybe a cfg_if!) - by ian-h-chamberlain

ps. thank @zetanumbers for investigating targets' compatibility

Sources

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

    - Source: https://sourceware.org/git/?p=newlib-cygwin.git;a=blob;f=newlib/libc/include/sys/stat.h;h=6525272dd40123d6ea4e7355a8e6f3a3f3d0dbb8;hb=HEAD
    - Note: If any platforms that meet the above criteria are added, they would need to create their own definition and use that (maybe a cfg_if!) - by @ian-h-chamberlain

    ps. thank @zetanumbers for checking targets
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 22, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@tgross35
Copy link
Copy Markdown
Contributor

Note that this should probably harmonize with #5069

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect newlib stat struct definition

3 participants