[v636][TPython] Fix LoadMacro for filenames containing special characters#22179
Open
guitargeek wants to merge 1 commit intoroot-project:v6-36-00-patchesfrom
Open
[v636][TPython] Fix LoadMacro for filenames containing special characters#22179guitargeek wants to merge 1 commit intoroot-project:v6-36-00-patchesfrom
LoadMacro for filenames containing special characters#22179guitargeek wants to merge 1 commit intoroot-project:v6-36-00-patchesfrom
Conversation
The implementation inserted the file name argument directly into a Python string literal delimited by double quotes, so any `"` in the name terminated the literal early and made the constructed source invalid (or, with a carefully crafted name, a different program than intended). Escape `\`, `"`, `\n` and `\r` in the name before using it, so that the whole name is used as a literal. Also add test coverage for filenames containing these special characters. (cherry picked from commit fac6e65)
Test Results 16 files 16 suites 2d 8h 39m 9s ⏱️ Results for commit c8aca99. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation inserted the file name argument directly into a Python string literal delimited by double quotes, so any
"in the name terminated the literal early and made the constructed source invalid (or, with a carefully crafted name, a different program than intended). Escape\,",\nand\rin the name before using it, so that the whole name is used as a literal.Also add test coverage for filenames containing these special characters.
(cherry picked from commit fac6e65)