close
Skip to content

[codex] export NotificationList#388

Merged
zombieJ merged 1 commit intomasterfrom
codex/export-notification-list
May 6, 2026
Merged

[codex] export NotificationList#388
zombieJ merged 1 commit intomasterfrom
codex/export-notification-list

Conversation

@zombieJ
Copy link
Copy Markdown
Member

@zombieJ zombieJ commented May 6, 2026

Summary

  • Export NotificationList from the package source entry.

Validation

  • npm run lint (passes with existing hook dependency warnings)

No test cases added per request.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
notification Error Error May 6, 2026 6:54am

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 6, 2026

Walkthrough

src/index.ts 中扩展公开API,导出 NotificationList 组件及其相关类型定义(NotificationListConfig、NotificationListProps、NotificationListClassNames、NotificationListStyles、Placement、StackConfig)。

Changes

公开API扩展

层级 / 文件 摘要
导入声明
src/index.ts
添加 NotificationList 组件的导入和相关类型导入(NotificationListConfig、NotificationListProps、NotificationListClassNames、NotificationListStyles、Placement、StackConfig)。
导出声明
src/index.ts
将 NotificationList 组件及其关联的七个类型添加到公开导出列表中。

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

🐰 NotificationList 登场亮相,
类型导出铺路,
公开舞台已备好,
用户触手可及,
完整API,圆满!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed PR标题准确总结了主要变化,即导出NotificationList组件及其相关类型到公共API。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/export-notification-list

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.19%. Comparing base (194d592) to head (8f9d69b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #388   +/-   ##
=======================================
  Coverage   99.19%   99.19%           
=======================================
  Files          13       13           
  Lines        1365     1366    +1     
  Branches      180      180           
=======================================
+ Hits         1354     1355    +1     
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the main entry point src/index.ts to export the NotificationList component along with its associated types and configurations, such as NotificationListProps, Placement, and StackConfig. I have no feedback to provide as there are no review comments.

@zombieJ zombieJ marked this pull request as ready for review May 6, 2026 06:53
@zombieJ zombieJ force-pushed the codex/export-notification-list branch from 978ab10 to 8f9d69b Compare May 6, 2026 06:54
@zombieJ zombieJ merged commit 4f16cb8 into master May 6, 2026
9 of 10 checks passed
@zombieJ zombieJ deleted the codex/export-notification-list branch May 6, 2026 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant