feat: java installation ui improvements#5731
Open
creeperkatze wants to merge 9 commits intomodrinth:mainfrom
Open
feat: java installation ui improvements#5731creeperkatze wants to merge 9 commits intomodrinth:mainfrom
creeperkatze wants to merge 9 commits intomodrinth:mainfrom
Conversation
Signed-off-by: Arthur <creeperkatze.dev@gmail.com>
|
Can you rebase on main - most likely conflicts as we touched app/instance settings |
Contributor
Author
|
Already dealt with the conflicts when the instance settings stuff was updated, clean |
Signed-off-by: Arthur <contact@creeperkatze.dev>
Contributor
Author
|
Also updated to StyledButton! |
Contributor
Author
|
There seems to be an issue with status icon coloring after migrating to StyledButton, will fix that and also make sure everything still works like it did when I initially tested it. |
IMB11
reviewed
May 3, 2026
Contributor
Author
|
Clean |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New pr since ive managed to mess up the history.
Improves the Java installation UI in both the app and instance settings. The manual test button is replaced with an auto-test that runs on load and on path change, showing a status indicator next to the input that also acts as a refresh button. This also gets rid of the overflow in the app settings.
The instance settings now use a card layout with a "Custom Java installation" checkbox for consistency with the other options. Also fixes button disabled state transitions being too slow globally.
App.settings.mp4
Instance.settings.mp4