fix(goose): declare args parameter in generated recipes

[natelastname]

Description

Fixes an issue in the Goose integration where generated recipes include {{args}} in the prompt but do not declare a corresponding args parameter.

This causes goose recipe validate to fail with:

Missing definitions for parameters in the recipe file: args.

The fix overrides _render_yaml in GooseIntegration to include a parameters section declaring the args parameter, ensuring all generated recipes are valid.

Testing

• Tested locally with uv run specify --help
• Ran existing tests with uv sync --extra test && uv run pytest
• Tested with a sample project (generated recipes and validated all with goose recipe validate)

AI Disclosure

• I did use AI assistance (describe below)

Consulted ChatGPT to reason through the root cause and propose an implementation approach. Final code and validation were done manually.

[mnriem]

Can you add some positive and negative tests?

[natelastname]

Can you add some positive and negative tests?

Sure, please let me know if there's anything else I can do.

[Copilot]

Pull request overview

Fixes Goose YAML recipe generation so recipes that include {{args}} also declare an args parameter, preventing goose recipe validate failures.

Changes:

• Override GooseIntegration._render_yaml to emit a parameters section declaring args.
• Add integration tests asserting generated Goose recipes declare args when {{args}} appears in the prompt.
• Add a control test confirming the base YamlIntegration renderer does not declare parameters.

Show a summary per file

File	Description
src/specify_cli/integrations/goose/__init__.py	Adds Goose-specific YAML rendering that includes an args parameter definition.
tests/integrations/test_integration_goose.py	Adds tests verifying the new Goose renderer behavior and documenting the base renderer behavior.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 2/2 changed files
• Comments generated: 1

[mnriem]

Please address Copilot feedback

[natelastname]

Please address Copilot feedback

I just edited my previous commit to remove the unused import.

[Copilot]

Pull request overview

Fixes Goose integration YAML recipe generation so recipes that reference {{args}} declare a corresponding args parameter, preventing goose recipe validate failures.

Changes:

• Override GooseIntegration._render_yaml to emit a parameters section containing an args parameter.
• Add Goose-specific tests to ensure generated recipes that contain {{args}} include an args parameter declaration.

Show a summary per file

File	Description
src/specify_cli/integrations/goose/__init__.py	Overrides YAML rendering to include an args parameter in the recipe header.
tests/integrations/test_integration_goose.py	Adds regression tests for args parameter declaration behavior.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 2/2 changed files
• Comments generated: 3

[mnriem]

Please address Copilot feedback. If not applicable, please explain why

[natelastname]

Please address Copilot feedback. If not applicable, please explain why

Ok, done

[natelastname]

I added an additional check to ensure the ACP “Running recipe” notification only fires when the mapped recipe path actually exists, which brings it in line with the current behavior in execute_command (where a missing file results in Ok(None) and no execution).

Longer term, it might be worth introducing a dedicated event type in the agent.reply stream (e.g., RecipeStarted or CommandStarted). That would allow integrations built on top of agent.reply (e.g., ACP, the HTTP server, CLI) to react to command execution in a consistent and reliable way, rather than needing to duplicate execution heuristics on the caller side.