close
Skip to content

test(ui): bump timeout on SignUpStart unsafeMetadata test#8504

Merged
wobsoriano merged 1 commit intomainfrom
jacek/fix-signup-start-test-timeout
May 8, 2026
Merged

test(ui): bump timeout on SignUpStart unsafeMetadata test#8504
wobsoriano merged 1 commit intomainfrom
jacek/fix-signup-start-test-timeout

Conversation

@jacekradko
Copy link
Copy Markdown
Member

The new unsafeMetadata > does not throw when signUp.create rejects with an API error test added in #8500 is flaky — its async chain (multiple userEvent calls + waitFor + findByTestId + microtask flush) sits right at the 5s default timeout and has tipped over twice in a row on the changeset-release/main runner (5006ms, then ~5000ms). Bumping this one test to 15s so a marginally slower runner doesn't flip it red.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 7, 2026

🦋 Changeset detected

Latest commit: 83b1a8a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented May 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment May 7, 2026 10:29pm

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 7, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: af611911-122a-4fc5-8d98-d23339ab89f2

📥 Commits

Reviewing files that changed from the base of the PR and between 6408ab6 and 83b1a8a.

📒 Files selected for processing (2)
  • .changeset/signup-start-test-timeout.md
  • packages/ui/src/components/SignUp/__tests__/SignUpStart.test.tsx

📝 Walkthrough

Walkthrough

This PR makes a minimal change to address async test timeout issues. It increases the timeout window from the default to 15 seconds for an async test in SignUpStart that handles unsafeMetadata errors when signUp.create rejects with a ClerkAPIResponseError. The test adjustment prevents premature failures during microtask completion. A corresponding empty changeset file is added to document this fix.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and concisely summarizes the main change: bumping a timeout on a specific SignUpStart test related to unsafeMetadata.
Description check ✅ Passed The description is directly related to the changeset, providing context about the flaky test, the specific timeout issue, and the rationale for the 15s increase.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 7, 2026

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8504

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8504

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8504

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8504

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8504

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8504

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8504

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8504

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8504

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8504

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8504

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8504

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8504

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8504

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8504

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8504

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8504

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8504

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8504

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8504

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8504

commit: 83b1a8a

@wobsoriano wobsoriano merged commit ee17b74 into main May 8, 2026
43 checks passed
@wobsoriano wobsoriano deleted the jacek/fix-signup-start-test-timeout branch May 8, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants