Add snippets for Jetpack PiP and notifications by alabiaga · Pull Request #900 · android/snippets

alabiaga · 2026-05-05T19:06:18Z

Add code snippets for Jetpack PiP library

https://developer.android.com/reference/androidx/core/pip/package-summary

Start migrating embedded non snippet code samples for notification documentation in developer.android.com

Change-Id: Ia5887b6f73f0af4729544e1a30c82f915a58c054

snippet-bot · 2026-05-05T19:06:24Z

Here is the summary of changes.

You are about to add 3 region tags.

compose/snippets/src/main/java/com/example/compose/snippets/notifications/NotificationsSnippets.kt:28, tag android_notification_authenticated_action
compose/snippets/src/main/java/com/example/compose/snippets/pictureinpicture/NavOrVideoCallJpipActivity.kt:27, tag android_jpip_basic_impl
compose/snippets/src/main/java/com/example/compose/snippets/pictureinpicture/VideoPlaybackJpipActivity.kt:29, tag android_jpip_video_playback_impl

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

gemini-code-assist

Code Review

This pull request introduces new code snippets for Android notifications and Picture-in-Picture (PiP) functionality, including the addition of the androidx.core.pip dependency. The feedback identifies several critical runtime issues, such as an invalid Intent constructor call and uninitialized lateinit properties in the new PiP activities. There are also suggestions to improve Kotlin idiomaticity by removing unnecessary semicolons and correcting descriptive comments.

Change-Id: I39e13958f811889e70b72c6e71256da7c3e75e72

Change-Id: I4661f0db980c7fea5131c95101f9cefe147fd8ad

kkuan2011 · 2026-05-05T20:31:02Z

 import android.content.Intent
 import android.content.IntentFilter
 import android.os.Build
+import android.os.Bundle


Are these new imports in this file needed?

nope, must've added this by mistake. removing

kkuan2011 · 2026-05-05T20:31:47Z

    implementation(libs.androidx.appcompat)
    implementation(libs.androidx.core.ktx)
+    implementation(libs.androidx.core.pip)
+    implementation(libs.androidx.core.telecom)


is the telecom dependency needed?

core.pip is but i don't know why telecom was pulled in. I'll remove

kkuan2011 · 2026-05-05T20:40:15Z

+        }
+    }
+
+    override fun onDestroy() {


With Compose, instead of overriding activity lifecycle methods, I believe we prefer to use DisposableEffect inside a composable?

Fixed. Thanks Kat

kkuan2011 · 2026-05-05T20:41:35Z

+    private lateinit var pictureInPictureImpl: BasicPictureInPicture
+    override fun onCreate(savedInstanceState: Bundle?) {
+        super.onCreate(savedInstanceState)
+        pictureInPictureImpl = BasicPictureInPicture(this)


Do you need to clean up pictureInPictureImpl in this file too?

i did clean it up in both files

hm can you tell me which line number it is in this file? maybe I'm not seeing it..

i instantiate pictureInPictureImpl in line 32 vs inline on line 29 as suggested by the assistant

Change-Id: I2f1a9b5c2366c6d7bb416e146bebaa40f78fe414

kkuan2011 · 2026-05-05T22:18:55Z

+    private lateinit var pictureInPictureImpl: BasicPictureInPicture
+    override fun onCreate(savedInstanceState: Bundle?) {
+        super.onCreate(savedInstanceState)
+        pictureInPictureImpl = BasicPictureInPicture(this)


hm can you tell me which line number it is in this file? maybe I'm not seeing it..

kkuan2011 · 2026-05-05T22:20:25Z

 import androidx.compose.ui.platform.LocalContext
 import androidx.core.app.PictureInPictureModeChangedInfo
 import androidx.core.content.ContextCompat
+import androidx.core.content.ContextCompat.getMainExecutor


is this import needed? I do see it used in the other files though

removing..it's strange that these are getting added, as I am not touching this file at all.

Change-Id: I46f5785f220e884135395ae05246a2756de91848

alabiaga

thanks Kat

alabiaga · 2026-05-05T22:57:41Z

+    private lateinit var pictureInPictureImpl: BasicPictureInPicture
+    override fun onCreate(savedInstanceState: Bundle?) {
+        super.onCreate(savedInstanceState)
+        pictureInPictureImpl = BasicPictureInPicture(this)


i instantiate pictureInPictureImpl in line 32 vs inline on line 29 as suggested by the assistant

alabiaga · 2026-05-05T22:58:22Z

 import androidx.compose.ui.platform.LocalContext
 import androidx.core.app.PictureInPictureModeChangedInfo
 import androidx.core.content.ContextCompat
+import androidx.core.content.ContextCompat.getMainExecutor


removing..it's strange that these are getting added, as I am not touching this file at all.

alabiaga · 2026-05-06T01:40:54Z

Checking in, let's discuss offline any open issues that aren't resolve and I'll follow up.

alabiaga added 2 commits May 5, 2026 13:03

add snippets for jetpack pip and notifications

bedc9f2

Change-Id: Ia5887b6f73f0af4729544e1a30c82f915a58c054

Merge branch 'android:main' into main

17da2b4

alabiaga requested review from a team, kkuan2011 and yrezgui as code owners May 5, 2026 19:06

alabiaga requested a review from raystatic May 5, 2026 19:06

alabiaga requested a review from ashnohe May 5, 2026 19:06

gemini-code-assist Bot reviewed May 5, 2026

View reviewed changes

alabiaga added 2 commits May 5, 2026 13:32

fixes from gemini assist code review

b7955ef

Change-Id: I39e13958f811889e70b72c6e71256da7c3e75e72

add comment to replace null w/ valid activity

31de567

Change-Id: I4661f0db980c7fea5131c95101f9cefe147fd8ad

kkuan2011 reviewed May 5, 2026

View reviewed changes

fixes from review

8316289

Change-Id: I2f1a9b5c2366c6d7bb416e146bebaa40f78fe414

ashnohe approved these changes May 5, 2026

View reviewed changes

kkuan2011 approved these changes May 5, 2026

View reviewed changes

alabiaga added 2 commits May 5, 2026 16:52

Merge branch 'android:main' into main

0b158f9

remove unused import

7cb57c8

Change-Id: I46f5785f220e884135395ae05246a2756de91848

alabiaga commented May 5, 2026

View reviewed changes

Conversation

alabiaga commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

snippet-bot Bot commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alabiaga left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alabiaga commented May 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

alabiaga commented May 5, 2026 •

edited

Loading

snippet-bot Bot commented May 5, 2026 •

edited

Loading