[JXR] Swap out AudioRecord with MediaRecorder implementation#893
Draft
trambui09 wants to merge 2 commits intoandroid:mainfrom
Draft
[JXR] Swap out AudioRecord with MediaRecorder implementation#893trambui09 wants to merge 2 commits intoandroid:mainfrom
trambui09 wants to merge 2 commits intoandroid:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the startProjectedAudioRecording function to use MediaRecorder instead of AudioRecord and introduces an outputFile parameter. Feedback indicates that the MediaRecorder is not properly stopped or released, which will lead to resource leaks, and suggests handling potential exceptions from the prepare() method.
This comment was marked as off-topic.
This comment was marked as off-topic.
devbridie
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swap out AudioRecord with MediaRecorder implementation for record audio with projected context.