close
Skip to content

fix: avoid forwarding overlay props in Tailwind starter Modal#10027

Draft
tobiase wants to merge 1 commit intoadobe:mainfrom
tobiase:fix-tailwind-starter-modal-props
Draft

fix: avoid forwarding overlay props in Tailwind starter Modal#10027
tobiase wants to merge 1 commit intoadobe:mainfrom
tobiase:fix-tailwind-starter-modal-props

Conversation

@tobiase
Copy link
Copy Markdown

@tobiase tobiase commented May 7, 2026

Closes #10026

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
    • Not applicable: this is a starter wrapper prop-forwarding fix, and the starter does not appear to have existing tests for this component.
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
    • Not applicable: this updates starter code only.
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Validated locally with:

  • yarn install --immutable
  • yarn eslint --no-warn-ignored starters/tailwind/src/Modal.tsx
  • yarn lint

To verify manually, use the Tailwind starter Modal with overlay-control props such as isOpen, onOpenChange, and isDismissable. These props should remain on ModalOverlay and should not be forwarded to the inner React Aria Modal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tailwind starter Modal forwards overlay props to nested Modal

1 participant