using a table-based convert_hex_to_binary function for better speed#478
Merged
using a table-based convert_hex_to_binary function for better speed#478
Conversation
anonrig
approved these changes
Aug 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to #473
Using the search-params benchmark, we can use
benchmarks/bench_search_paramsto test the speed at which we can parse search parameters. This task is percent-decoding intensive.GCC 11, Ice Lake processor.
Main:
PR #473
Table approach:
The table-based approach more than 10% faster than our main branch and, according to these tests, faster than PR #473
cc @ttsugriy
This is a precursor to #459