close
Skip to content

ci: fix Codecov component paths#53

Merged
willkill07 merged 1 commit intoNVIDIA:mainfrom
willkill07:fix/codecov-component-paths
May 3, 2026
Merged

ci: fix Codecov component paths#53
willkill07 merged 1 commit intoNVIDIA:mainfrom
willkill07:fix/codecov-component-paths

Conversation

@willkill07
Copy link
Copy Markdown
Member

@willkill07 willkill07 commented May 3, 2026

Overview

Correct Codecov component path globs so they match repository-relative coverage paths instead of NeMo-Flow/...-prefixed paths.

  • I confirm this contribution is my own work, or I have the right to submit it under this project's license.
  • I searched existing issues and open pull requests, and this does not duplicate existing work.

Details

  • Removed the stale NeMo-Flow/ prefix from every component_management.individual_components[].paths entry.
  • Left Codecov thresholds, statuses, comment layout, and ignore rules unchanged.
  • Validation: git diff --check -- codecov.yml; Ruby YAML parse; rg -n "NeMo-Flow/" codecov.yml returned no matches; uv run pre-commit run --files codecov.yml.

Where should the reviewer start?

Start with codecov.yml, specifically the Codecov component path entries for Rust, Go, Python, Node.js, and WebAssembly.

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • Relates to: none

Summary by CodeRabbit

  • Chores
    • Updated code coverage configuration paths to improve monitoring consistency across runtime and binding components.

Signed-off-by: Will Killian <wkillian@nvidia.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 3, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: bf8334f2-9bda-4fb1-a0a0-2159abb7fb6d

📥 Commits

Reviewing files that changed from the base of the PR and between 280ded3 and 732af51.

📒 Files selected for processing (1)
  • codecov.yml

Walkthrough

Codecov configuration is updated to remove the NeMo-Flow/ directory prefix from component path globs for five bindings: rust_runtime, go_binding, python_binding, node_binding, and wasm_binding. Paths are adjusted to reference the relative repository structure.

Changes

Codecov Component Paths

Layer / File(s) Summary
Configuration
codecov.yml
Remove NeMo-Flow/ prefix from path globs across five components. Update rust_runtime (lines 46–50), go_binding (lines 57–61), python_binding (lines 68–72), node_binding (lines 79–82), and wasm_binding (lines 89–92). Paths now reference relative structure without the directory prefix (e.g., crates/... instead of NeMo-Flow/crates/...).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Review rate limit: 9/10 reviews remaining, refill in 6 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added size:S PR is small ci PR alters/improves CI labels May 3, 2026
@willkill07 willkill07 self-assigned this May 3, 2026
@willkill07 willkill07 added this to the 0.2.0 milestone May 3, 2026
@willkill07 willkill07 marked this pull request as ready for review May 3, 2026 23:59
@willkill07 willkill07 requested a review from a team as a code owner May 3, 2026 23:59
@willkill07 willkill07 merged commit 0829e78 into NVIDIA:main May 3, 2026
58 of 59 checks passed
@willkill07 willkill07 deleted the fix/codecov-component-paths branch May 4, 2026 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci PR alters/improves CI size:S PR is small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant