close
Skip to content

feat: Redundant self-harm onself, self-teach oneself, do self-harm to oneself, self host it oneself#3326

Open
hippietrail wants to merge 6 commits into
Automattic:masterfrom
hippietrail:self-harm-redundancy
Open

feat: Redundant self-harm onself, self-teach oneself, do self-harm to oneself, self host it oneself#3326
hippietrail wants to merge 6 commits into
Automattic:masterfrom
hippietrail:self-harm-redundancy

Conversation

@hippietrail
Copy link
Copy Markdown
Collaborator

@hippietrail hippietrail commented May 8, 2026

Issues

N/A

Description

Fixes various sentence patterns where "self" is used twice, first prefixed to a verb, and then as part of a reflexive pronoun.

  • self-harm oneself, self-teach oneself,
  • (do) self-harm to oneself
  • self-host (it) oneself

Handles all inflections of the verb and all pronouns, including ones like singular "them".

Avoids flagging things like "self harm itself is not the root cause".

BONUS I've included an extra bit of debug output in assert_good_and_bad_suggestions to print out suggestions not in either the good list of bad list. Really helps in cases where you have an out-by-one index or a missing full stop in one variant etc.

AI disclosure: I used Windsurf's coding AI to refactor some of my initial versions but beyond a certain point early on, I identified all the patterns to simplify it so the final version is basically all my code now.

How Has This Been Tested?

Examples from GitHub for the technical patterns, plus some from Stack Overflow/Exchange, and the rest from Medium and Reddit for the self-harm patterns.

Checklist

  • I have performed a self-review of my own code
  • I have added tests to cover my changes
  • I have considered splitting this into smaller pull requests.

@hippietrail hippietrail marked this pull request as draft May 11, 2026 05:18
@hippietrail hippietrail changed the title feat:self-harm onself→self-harm/harm oneself feat: Redundant self-harm onself, self-teach oneself, do self-harm to oneself, self host it oneself May 11, 2026
@hippietrail hippietrail marked this pull request as ready for review May 11, 2026 09:23
@hippietrail
Copy link
Copy Markdown
Collaborator Author

This might happen in more verbs that I thought:

  • How can she self-humiliate herself so much?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant