feat: Redundant self-harm onself, self-teach oneself, do self-harm to oneself, self host it oneself#3326
Open
hippietrail wants to merge 6 commits into
Open
feat: Redundant self-harm onself, self-teach oneself, do self-harm to oneself, self host it oneself#3326hippietrail wants to merge 6 commits into
hippietrail wants to merge 6 commits into
Conversation
Collaborator
Author
|
This might happen in more verbs that I thought:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
N/A
Description
Fixes various sentence patterns where "self" is used twice, first prefixed to a verb, and then as part of a reflexive pronoun.
Handles all inflections of the verb and all pronouns, including ones like singular "them".
Avoids flagging things like "self harm itself is not the root cause".
BONUS I've included an extra bit of debug output in
assert_good_and_bad_suggestionsto print out suggestions not in either the good list of bad list. Really helps in cases where you have an out-by-one index or a missing full stop in one variant etc.AI disclosure: I used Windsurf's coding AI to refactor some of my initial versions but beyond a certain point early on, I identified all the patterns to simplify it so the final version is basically all my code now.
How Has This Been Tested?
Examples from GitHub for the technical patterns, plus some from Stack Overflow/Exchange, and the rest from Medium and Reddit for the self-harm patterns.
Checklist