feat: better linter assert failure mode reporting#3230
Open
hippietrail wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
N/A
Description
I noticed while working on linters that it's sometimes hard to know how/why
assert_suggestion_result()failed.Expr/Patterndidn't even match.Suggestions are what were expected.This PR adds a few emojis: ❌ for when it fails for any reason, followed by the reason. 🎯 for the expected
Suggestion. 🔍 for the first actualSuggestion.If there are multiple failing
Suggestions, only the first is shown, but it's followed by the number of other failing ones. This can be changed if need be.Disclaimer: The built-in LLM in Windsurf (
SWE-1.5) did most of the actual code changes. I guided it closely and I did most of the testing manually.Demo
How Has This Been Tested?
#[ignore]d tests from various linters for "real world" testing.Checklist