close
Skip to content

Add Sized supertrait for CoerceUnsized and DispatchFromDyn#154935

Merged
rust-bors[bot] merged 3 commits intorust-lang:mainfrom
Darksonn:dyn-trait-dyn-compat
Apr 18, 2026
Merged

Add Sized supertrait for CoerceUnsized and DispatchFromDyn#154935
rust-bors[bot] merged 3 commits intorust-lang:mainfrom
Darksonn:dyn-trait-dyn-compat

Conversation

@Darksonn
Copy link
Copy Markdown
Member

@Darksonn Darksonn commented Apr 7, 2026 •
edited by rustbot
Loading

This is part of #149094. I did not include Receiver because I think it is correct to allow non-sized receivers.

@Darksonn Darksonn added F-dispatch_from_dyn `#![feature(dispatch_from_dyn)]` F-coerce_unsized The `CoerceUnsized` trait A-dyn-compatibility Area: Dyn compatibility (formerly: object safety) labels Apr 7, 2026
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 7, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 7, 2026

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @scottmcm, libs
  • @scottmcm, libs expanded to 8 candidates
  • Random selection from Mark-Simulacrum, jhpratt, scottmcm

@Darksonn
Copy link
Copy Markdown
Member Author

Darksonn commented Apr 7, 2026

cc @dingxiangfei2009

@ojeda ojeda mentioned this pull request Apr 8, 2026
Open
51 tasks
@scottmcm
Copy link
Copy Markdown
Member

scottmcm commented Apr 18, 2026

@bors r+

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 18, 2026

📌 Commit 46a84f6 has been approved by scottmcm

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 18, 2026
@jhpratt jhpratt mentioned this pull request Apr 18, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Apr 18, 2026
@bors
Auto merge of #155472 - jhpratt:rollup-cFOYOWJ, r=jhpratt
7a38981 
Rollup of 12 pull requests

Successful merges:

 - #147811 (naked functions: respect `function-sections`)
 - #154935 (Add Sized supertrait for CoerceUnsized and DispatchFromDyn)
 - #139690 (`impl Default for RepeatN`)
 - #153511 (`std::any::TypeId`: remove misplaced "and" in `Unique<T>` example)
 - #154943 (Move recursion out of `MatchPairTree::for_pattern` helpers )
 - #155295 (Fix misleading "borrowed data escapes outside of function" diagnostic)
 - #155427 (ptr: update text in intro text to one in with_addr doc)
 - #155428 (Fix ICE in borrowck mutability suggestion with multi-byte ref sigil)
 - #155435 (rustdoc: Fix `redundant_explicit_links` incorrectly firing (or not firing) under certain scenarios)
 - #155450 (Remove unnecessary safety conditions related to unchecked uint arithmetic)
 - #155454 (docs: Fix typo in std/src/thready/scoped.rs)
 - #155467 (`std::error::Request`: clean up documentation)
@rust-bors rust-bors bot merged commit db3d084 into rust-lang:main Apr 18, 2026
11 checks passed
@rustbot rustbot added this to the 1.97.0 milestone Apr 18, 2026
rust-timer added a commit that referenced this pull request Apr 18, 2026
@rust-timer
Unrolled build for #154935
be6a7fb 
Rollup merge of #154935 - Darksonn:dyn-trait-dyn-compat, r=scottmcm

Add Sized supertrait for CoerceUnsized and DispatchFromDyn

This is part of #149094. I did not include `Receiver` because I think it is correct to allow non-sized receivers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@scottmcm scottmcm

Labels

A-dyn-compatibility Area: Dyn compatibility (formerly: object safety) F-coerce_unsized The `CoerceUnsized` trait F-dispatch_from_dyn `#![feature(dispatch_from_dyn)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Darksonn @rustbot @scottmcm