FIX: Don't try to generate Gargo.lock on empty workspaces.#3092
Merged
bors merged 1 commit intorust-lang:masterfrom Sep 14, 2016
jhbabon:fix/dont-panic-on-workspaces
Merged
FIX: Don't try to generate Gargo.lock on empty workspaces.#3092bors merged 1 commit intorust-lang:masterfrom jhbabon:fix/dont-panic-on-workspaces
bors merged 1 commit intorust-lang:masterfrom
jhbabon:fix/dont-panic-on-workspaces
Conversation
There was a panic! when the command `cargo update` was
executed in a workspace like this:
mkdir ws
cd ws
echo '[workspace]' > Cargo.toml
cargo new p1
cargo new p2
cargo update
The problem is that cargo tries to generate the Cargo.lock file
even if there aren't any members on the workspace.
This fix checks the existence of members in the workspace before trying
to do anything so at least we report an error instead of throwing a
panic!
Member
Contributor
bors
added a commit
that referenced
this pull request
Sep 14, 2016
…chton
FIX: Don't try to generate Gargo.lock on empty workspaces.
There was a `panic!` when the command `cargo update` was executed in a workspace like this:
mkdir ws
cd ws
echo '[workspace]' > Cargo.toml
cargo new p1
cargo new p2
cargo update
The problem is that cargo tries to generate the `Cargo.lock` file even if there aren't any members on the workspace.
This fix checks the existence of members in the workspace before trying to do anything so at least we report an error instead of throwing a `panic!`.
Issue related #3080
Contributor
|
☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 |
Contributor
Author
|
Cool, thanks @alexcrichton I must say that this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a
panic!when the commandcargo updatewas executed in a workspace like this:The problem is that cargo tries to generate the
Cargo.lockfile even if there aren't any members on the workspace.This fix checks the existence of members in the workspace before trying to do anything so at least we report an error instead of throwing a
panic!.Issue related #3080