close
Skip to content

Map types#66

Merged
dahlia merged 3 commits intonirum-lang:masterfrom
dahlia:map
Mar 20, 2017
Merged

Map types#66
dahlia merged 3 commits intonirum-lang:masterfrom
dahlia:map

Conversation

@dahlia
Copy link
Copy Markdown
Member

@dahlia dahlia commented Mar 19, 2017

Although the runtime library already had had serializer and deserializer for maps, they weren't correctly implemented according to the spec. Map should be encoded as an array of objects e.g. [{"key": ..., "value": ...}] since keys can be more than primitive types, but it had encoded map as an object e.g. {...: ...}.

Also, as Python doesn't offset immutable dict, I implemented a simple immutable dict. Though its name is Map to follow Nirum's own terms.

@dahlia dahlia self-assigned this Mar 19, 2017
@dahlia dahlia requested a review from kanghyojun March 19, 2017 17:37
@kanghyojun
Copy link
Copy Markdown
Member

이거 머지하면 0.3-maintanence 마스터에 머지하고 닫아야겠네요

@dahlia dahlia merged commit 4d43a1e into nirum-lang:master Mar 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants