Merged
Conversation
kanghyojun
approved these changes
Mar 20, 2017
Member
|
이거 머지하면 0.3-maintanence 마스터에 머지하고 닫아야겠네요 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although the runtime library already had had serializer and deserializer for maps, they weren't correctly implemented according to the spec. Map should be encoded as an array of objects e.g.
[{"key": ..., "value": ...}]since keys can be more than primitive types, but it had encoded map as an object e.g.{...: ...}.Also, as Python doesn't offset immutable
dict, I implemented a simple immutabledict. Though its name isMapto follow Nirum's own terms.