Fix missing header from GitLab blog page#885
Merged
fchasen merged 3 commits intomozilla:mainfrom Jun 27, 2024
Merged
Conversation
|
Thanks for submitting the test case and fix, the simpler fix for this seem to be to just remove |
Contributor
Author
|
Wasn't it added there with a reason? Maybe there is a test case missing for that part of the regex? 🤔 |
Contributor
Author
|
Oh, it's there since the initial commit. So, should I remove |
|
Yep, seems to be fine to remove completely. |
fchasen
requested changes
Jun 27, 2024
d075c1e to
4ec95b4
Compare
Co-authored-by: Fred Chasen <fchasen@gmail.com>
fchasen
approved these changes
Jun 27, 2024
|
Thanks again for the text case that has most of the text of the header in the id, that pattern doesn't work great with regex matching (for instance if the header was about |
Contributor
Author
|
Good job with the contribution instructions 👏🏻 Was thinking about creating an issue at first 😅 |
mislav
added a commit
to mislav/go-readability
that referenced
this pull request
Jun 19, 2025
This ports "Fix missing header from GitLab blog page" (mozilla/readability#885)
mislav
added a commit
to mislav/go-readability
that referenced
this pull request
Jun 23, 2025
This ports "Fix missing header from GitLab blog page" (mozilla/readability#885)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.