make sure elements are not deleted if they contain a data table#858
Merged
gijsk merged 2 commits intomozilla:mainfrom May 17, 2024
Merged
make sure elements are not deleted if they contain a data table#858gijsk merged 2 commits intomozilla:mainfrom
gijsk merged 2 commits intomozilla:mainfrom
Conversation
1971:32 error Multiple spaces found before '||' no-multi-spaces 2110:41 error Strings must use doublequote quotes
gijsk
approved these changes
May 17, 2024
Contributor
gijsk
left a comment
There was a problem hiding this comment.
Thanks, this looks great! Apologies it took a long time to get to the review.
mislav
added a commit
to mislav/go-readability
that referenced
this pull request
Jun 19, 2025
This ports "make sure elements are not deleted if they contain a data table" (mozilla/readability#858)
mislav
added a commit
to mislav/go-readability
that referenced
this pull request
Jun 23, 2025
This ports "make sure elements are not deleted if they contain a data table" (mozilla/readability#858)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses issue #775 where a data table got removed because the owning element was considered removable.