feat: Added comma regular expressions#796
Merged
gijsk merged 3 commits intomozilla:mainfrom Apr 25, 2023
Merged
Conversation
…and for vertical writing
Fix the lint issue, drop ʻOkina and clarify comment a little bit.
gijsk
approved these changes
Apr 24, 2023
Contributor
gijsk
left a comment
There was a problem hiding this comment.
Thanks! I've fixed the linting issue (missing space) and dropped the ʻOkina character which isn't really a comma. I'll update the wikipedia page. I think there are more commas we could add support for, but this is an improvement so let's start here.
Contributor
|
Looks like this still breaks the 'qq' test. :-( I'll try to find some time to work out why and/or if the result is better/worse. |
Contributor
Author
|
Well, look forward to your merger. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added commas for German, Hawaiian, Chinese and other languages and for vertical writing