Fix crash in FilteredReadStream on task cancellation#6545
Fix crash in FilteredReadStream on task cancellation#6545emilk wants to merge 1 commit intolance-format:mainfrom
FilteredReadStream on task cancellation#6545Conversation
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
.unwrap() with ?FilteredReadStream on task cancellation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
This unwrap is doing panic propagation, a panic in the spawned task will propagate into the parent. This is done in quite a few places (e.g. mutexes, other spanwed tasks) throughout the code base. I can see advantages to translating those into errors but I'm curious if there is any particular reason this call site has been a bother? |
No description provided.