close
Skip to content

fix(bigquery): fix arrow deprecation warning#9504

Merged
tswast merged 1 commit intogoogleapis:masterfrom
plamut:iss-9485
Oct 22, 2019
Merged

fix(bigquery): fix arrow deprecation warning#9504
tswast merged 1 commit intogoogleapis:masterfrom
plamut:iss-9485

Conversation

@plamut
Copy link
Copy Markdown
Contributor

@plamut plamut commented Oct 20, 2019

Fixes #9485.

This PR fixes a warning that can be issued when downloading results as pyarrow record batches.

The warning was caused by pyarrow, because a pyarrow schema was passed as the names argument, instead of as the schema argument, and pyarrow started raising a warning for it in version 0.15.0 (source code).

Steps to reproduce

  • Make sure pyarrow 0.15.0+ is installed (there is no warning in prior versions),
  • Run query_to_arrow test,

Actual result (before the fix):
A pyarrow FutureWarning is issued (as described in the issue description).

Expected result (after the fix):
No warning is issued, everything works as expected.

This commit fixes a warning that can be issued when downloading
results as pyarrow record batches.
@plamut plamut added the api: bigquery Issues related to the BigQuery API. label Oct 20, 2019
@plamut plamut requested a review from a team October 20, 2019 12:19
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 20, 2019
@tswast tswast merged commit 4644da1 into googleapis:master Oct 22, 2019
@plamut plamut deleted the iss-9485 branch October 23, 2019 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BigQuery: pyarrow warning about schema argument

3 participants