close
Skip to content

docs(tasks): disambiguate client requests from cloud task requests#9398

Merged
busunkim96 merged 2 commits intogoogleapis:masterfrom
busunkim96:tasks-docstrings
Oct 8, 2019
Merged

docs(tasks): disambiguate client requests from cloud task requests#9398
busunkim96 merged 2 commits intogoogleapis:masterfrom
busunkim96:tasks-docstrings

Conversation

@busunkim96
Copy link
Copy Markdown
Contributor

CC/ @averikitsch

Addressing internal issue 136504997

The create_task method refers to optional parameters - retry, timeout, and metadata. It is unclear to users that theses are configuration parameters for the client request not Cloud Task requests. (https://googleapis.dev/python/cloudtasks/latest/gapic/v2/api.html#google.cloud.tasks_v2.CloudTasksClient.create_task)

Please update the language to reflect that these affect the client request not Cloud Tasks.

Any wording suggestions would be much appreciated.

@busunkim96 busunkim96 added the api: cloudtasks Issues related to the Cloud Tasks API. label Oct 4, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 4, 2019
@busunkim96 busunkim96 requested a review from crwilcox October 7, 2019 17:50
@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 8, 2019
@busunkim96 busunkim96 merged commit 8e409a0 into googleapis:master Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: cloudtasks Issues related to the Cloud Tasks API. cla: yes This human has signed the Contributor License Agreement. kokoro:force-run Add this label to force Kokoro to re-run the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants