BigQuery: Add 'max_results' param to 'QueryJob.result()'.#9167
Merged
tswast merged 2 commits intogoogleapis:masterfrom Sep 4, 2019
Merged
Conversation
tswast
reviewed
Sep 3, 2019
Contributor
tswast
left a comment
There was a problem hiding this comment.
I know it's a bit silly to do so, but let's add a unit test to the test_job.py module to make sure max_results works as expected.
emar-kar
pushed a commit
to MaxxleLLC/google-cloud-python
that referenced
this pull request
Sep 11, 2019
* added max_results param to QueryJob.result() * added test to check that max_results param appears in tabledata.list call arguments
emar-kar
pushed a commit
to MaxxleLLC/google-cloud-python
that referenced
this pull request
Sep 18, 2019
* added max_results param to QueryJob.result() * added test to check that max_results param appears in tabledata.list call arguments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of 3 PRs towards resolving #9105 as described in review for #9147