BigQuery: Add StandardSqlDataTypes enum to BigQuery#8782
BigQuery: Add StandardSqlDataTypes enum to BigQuery#8782plamut merged 6 commits intogoogleapis:masterfrom
Conversation
|
Looks like we might need to pin one of the dependencies (pyarrow?) to fix our tests. |
|
Yeah, I've already been discussing this with @tswast, it's how pyarrow (?) handles |
This is a convenience enum that contains scalar SQL data types constants (a subsset of types defined in the gapic enum generated from the .proto definitions).
tswast
left a comment
There was a problem hiding this comment.
LGTM once the docs update is in.
| "Encoding", | ||
| "QueryPriority", | ||
| "SchemaUpdateOption", | ||
| "StandardSqlDataTypes", |
There was a problem hiding this comment.
This reminds me: let's add an Enums section to the API reference docs, too.
https://github.com/googleapis/google-cloud-python/blob/master/bigquery/docs/reference.rst
There was a problem hiding this comment.
Added. Also had to inject an additional header line to the new enum's docstring, because Sphinx complained about a duplicate object description (took the first line - the INT64 member - which is of course directly copied from the gapic enum).
Closes #8495.
This PR adds a convenience enum with scalar SQL data types (as per issue description).
How to test
The issue is self-explanatory. Just make sure that the enum contains all the right fields that we want in it.
Update: Additionally, make sure that the docs for the new enum are in order.