close
Skip to content

Fixed testcase failures when build directory is not under the source directory#206

Merged
shenhanc78 merged 1 commit intogoogle:masterfrom
shenhanc78:dev_branch_2
Jul 16, 2024
Merged

Fixed testcase failures when build directory is not under the source directory#206
shenhanc78 merged 1 commit intogoogle:masterfrom
shenhanc78:dev_branch_2

Conversation

@shenhanc78
Copy link
Copy Markdown
Collaborator

"../testdata" assumes the build directory is inside the source directory, which is not always true. Fixed this by using the source directory explicitly.

…directory.

"../testdata" assumes the build directory is inside the source
directory, which is not always true.  Fixed this by using the source
directory explicitly.
Copy link
Copy Markdown
Collaborator

@xur-llvm xur-llvm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shenhanc78 shenhanc78 merged commit c231b3b into google:master Jul 16, 2024
@shenhanc78 shenhanc78 deleted the dev_branch_2 branch July 16, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants