Ensure TextPainters are disposed when possible.#8902
Merged
srawlins merged 6 commits intoflutter:masterfrom Feb 18, 2025
Merged
Ensure TextPainters are disposed when possible.#8902srawlins merged 6 commits intoflutter:masterfrom
srawlins merged 6 commits intoflutter:masterfrom
Conversation
There are a few ways in which TextPainters are used: * To get the width of what would be rendered; in this case, we delegate all implementations to calculateTextSpanWidth. We then `dispose` the TextPainter in that function. * To instantiate, layout, and paint exactly once; in this case, we `dispose` immediately after painting, as the documentation says we should. * To be passed to a CustomPainter. in these cases, I think it is not safe to immediately dispose. I'm not sure what the expected workflow is.
Comment on lines
-536
to
-541
| // Draw vertical tick (short or long). | ||
| canvas.drawLine( | ||
| Offset(xTickCoord, 0), | ||
| Offset(xTickCoord, shortTick ? 2 : 6), | ||
| axis, | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
displayTime is always passed as true. This was revealed by making the method private.
srawlins
commented
Feb 18, 2025
Comment on lines
-536
to
-541
| // Draw vertical tick (short or long). | ||
| canvas.drawLine( | ||
| Offset(xTickCoord, 0), | ||
| Offset(xTickCoord, shortTick ? 2 : 6), | ||
| axis, | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
displayTime is always passed as true. This was revealed by making the method private.
kenzieschmoll
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a few ways in which TextPainters are used:
disposethe TextPainter in that function.disposeimmediately after painting, as the documentation says we should.Work towards #5888