Fix memory management issue with the table widget#8901
Merged
kenzieschmoll merged 4 commits intoflutter:masterfrom Feb 18, 2025
Merged
Fix memory management issue with the table widget#8901kenzieschmoll merged 4 commits intoflutter:masterfrom
kenzieschmoll merged 4 commits intoflutter:masterfrom
Conversation
kenzieschmoll
commented
Feb 15, 2025
| void dispose() { | ||
| verticalScrollController?.dispose(); | ||
| verticalScrollController = null; | ||
| _tableData.dispose(); |
Member
Author
There was a problem hiding this comment.
all notifiers should be disposed.
kenzieschmoll
commented
Feb 15, 2025
|
|
||
| @override | ||
| void dispose() { | ||
| _tableController?.dispose(); |
Member
Author
There was a problem hiding this comment.
objects should be disposed by their creator.
elliette
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of a series of memory management work for DevTools.