close
Skip to content

Release as latest#797

Merged
ericcurtin merged 2 commits intomainfrom
release-as-latest
Mar 27, 2026
Merged

Release as latest#797
ericcurtin merged 2 commits intomainfrom
release-as-latest

Conversation

@ilopezluna
Copy link
Copy Markdown
Contributor

This pull request removes the separate workflow for promoting Docker images to the latest tag and streamlines the release process by always tagging built images as latest within the main release workflow. The previous option to conditionally push the latest tag using the pushLatest input has been eliminated, and the logic for promoting images is now handled directly in the release workflow.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@ilopezluna ilopezluna requested a review from a team March 26, 2026 18:56
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The inline shell that builds the Docker tags is now quite repetitive; consider using a small loop over the variants (cpu, cuda, vllm-cuda, etc.) to generate both $RELEASE_TAG and latest tags to reduce duplication and the chance of inconsistencies on future edits.
  • Now that every run pushes latest, it may be worth explicitly constraining when the release workflow can be triggered (e.g., only on tagged releases or excluding prerelease tags) so that accidental or prerelease runs don’t overwrite the latest image.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The inline shell that builds the Docker tags is now quite repetitive; consider using a small loop over the variants (cpu, cuda, vllm-cuda, etc.) to generate both `$RELEASE_TAG` and `latest` tags to reduce duplication and the chance of inconsistencies on future edits.
- Now that every run pushes `latest`, it may be worth explicitly constraining when the release workflow can be triggered (e.g., only on tagged releases or excluding prerelease tags) so that accidental or prerelease runs don’t overwrite the `latest` image.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ericcurtin ericcurtin merged commit dd9b9d4 into main Mar 27, 2026
12 checks passed
@ericcurtin ericcurtin deleted the release-as-latest branch March 27, 2026 12:30
Copy link
Copy Markdown
Contributor

@doringeman doringeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants