Merged
Conversation
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The inline shell that builds the Docker tags is now quite repetitive; consider using a small loop over the variants (cpu, cuda, vllm-cuda, etc.) to generate both
$RELEASE_TAGandlatesttags to reduce duplication and the chance of inconsistencies on future edits. - Now that every run pushes
latest, it may be worth explicitly constraining when the release workflow can be triggered (e.g., only on tagged releases or excluding prerelease tags) so that accidental or prerelease runs don’t overwrite thelatestimage.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The inline shell that builds the Docker tags is now quite repetitive; consider using a small loop over the variants (cpu, cuda, vllm-cuda, etc.) to generate both `$RELEASE_TAG` and `latest` tags to reduce duplication and the chance of inconsistencies on future edits.
- Now that every run pushes `latest`, it may be worth explicitly constraining when the release workflow can be triggered (e.g., only on tagged releases or excluding prerelease tags) so that accidental or prerelease runs don’t overwrite the `latest` image.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
ericcurtin
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes the separate workflow for promoting Docker images to the
latesttag and streamlines the release process by always tagging built images aslatestwithin the main release workflow. The previous option to conditionally push thelatesttag using thepushLatestinput has been eliminated, and the logic for promoting images is now handled directly in the release workflow.