feat: update rename functionality

[cdaguerre]

Hi,
To my understanding, the current rename implementation doesn't work anymore.
I'm even wondering if it worked at some point because of the comment that @lexi-lambda made in the PR description: atom/atom-languageclient#270

Anyways, it seemed to rely on the archived atom-ide-ui...

So here's a draft PR to suggest two different implementations:

• Intentions (cdaguerre@35f957e)
• Commands and context menu (cdaguerre@0516e36)

Both approaches have advantages and drawbacks, eg.

Commands and context menu

• You can't conditionally disable context menu items asynchronously: the refactor > rename item is always available and will trigger an error when no rename is possible at the given position
• I found no way to pass the mousevent click position to the command, so the command uses the text editor's buffer position which we set manually on context menu right click.

Intentions

• Feels less "native"
• No right click possible, requires a keybinding
• Rename action is only suggested when possible (using LSP prepare functionality)

[UziTech]

I actually created a dialog view for some other atom packages https://github.com/UziTech/atom-modal-views. Do we want to use that instead of creating our own?

/cc @aminya

[aminya]

I actually created a dialog view for some other atom packages UziTech/atom-modal-views. Do we want to use that instead of creating our own?

That sounds like a good plan! I love reusing code.

[aminya]

The last time I checked the intentions package was quite buggy. For example, it disabled selecting the text, or the underlines were longer than what they should be. I thought @steelbrain had stopped supporting it.
steelbrain/intentions#76
steelbrain/intentions#74
steelbrain/intentions#77

So, if we need to add a new package for renaming I am ok with it.

[aminya]

I got access to the intentions package. We should fix these issues before merging this PR.

• The tests are failing in new Atom steelbrain/intentions#76
• Intentions disables double clicking  steelbrain/intentions#74
• atom-ide-base disables intentions automatically  steelbrain/intentions#77

[ivan94fi]

Hi, any updates on this functionality? Will this be merged in the near future?

Thank you all from atom-community for your work!