close
Skip to content

Feature/fix image write issue#297

Merged
psxjoy merged 4 commits intoapache:mainfrom
alaahong:feature/fix_image_write_issue_20250330
Mar 31, 2025
Merged

Feature/fix image write issue#297
psxjoy merged 4 commits intoapache:mainfrom
alaahong:feature/fix_image_write_issue_20250330

Conversation

@alaahong
Copy link
Copy Markdown
Member

Update not found resource and suggest file type for another solution
Before Change:
image

image

Post Change:
image

Update not found resource and suggest file type for another solution
rollback useless change
Update not found resource and suggest file type for another solution
Copy link
Copy Markdown
Member

@psxjoy psxjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, we’ve revised the code style guidelines. Would you mind updating your code to align with the project’s current standards?

Hi,我们已经更新了codestyle,能否更新一下代码,确保符合项目的代码规范呢?

@alaahong
Copy link
Copy Markdown
Member Author

Hi, we’ve revised the code style guidelines. Would you mind updating your code to align with the project’s current standards?

Hi,我们已经更新了codestyle,能否更新一下代码,确保符合项目的代码规范呢?

Thanks for your following, please point out the code style guidelines?
Otherwise, how about to export one IDE setting to align the coding format?

image

@psxjoy
Copy link
Copy Markdown
Member

psxjoy commented Mar 31, 2025

Hi, we’ve revised the code style guidelines. Would you mind updating your code to align with the project’s current standards?
Hi,我们已经更新了codestyle,能否更新一下代码,确保符合项目的代码规范呢?

Thanks for your following, please point out the code style guidelines? Otherwise, how about to export one IDE setting to align the coding format?

image

  1. https://www.jetbrains.com/help/idea/settings-code-style-xml.html
  2. https://github.com/fast-excel/fastexcel/tree/main/style/codestyle

just format the code as suggested style
Copy link
Copy Markdown
Member

@psxjoy psxjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@psxjoy psxjoy merged commit 6d11dcb into apache:main Mar 31, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants