Use entity link title for link control preview#77155
Merged
Conversation
If we are displaying a bound entity link, use the bound entity link title in the link control preview. If there is none, fallback to the current system of richData.title, navigation link block title, then url.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +24 B (0%) Total Size: 7.74 MB 📦 View Changed
ℹ️ View Unchanged
|
|
Flaky tests detected in 3befe95. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/24144124157
|
t-hamano
approved these changes
Apr 9, 2026
Contributor
t-hamano
left a comment
There was a problem hiding this comment.
LGTM! This change makes sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
#77057 exposed an inconsistency between the sidebar inspector link preview and link control link preview. The link title shows the RichData title which often includes the site. This wasn't our design intention for the link previews.
Why?
Consistency between link previews.
How?
When we have a bound entity link, we should use the bound entity link title in the link control preview. If there is none, fallback to
richText.title || navigation block title || navigation block urlTesting Instructions
Page title - site titleTesting Instructions for Keyboard
Screenshots or screencast
Screen.Recording.2026-04-08.at.10.36.02.AM.mov
Use of AI Tools
Assistance from Claude Sonnet 4.6