Enhancement : Attach images to post uploaded in core/image block via media library#70313
Enhancement : Attach images to post uploaded in core/image block via media library#70313Vrishabhsk wants to merge 1 commit intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| "@wordpress/date": "file:../date", | ||
| "@wordpress/deprecated": "file:../deprecated", | ||
| "@wordpress/dom": "file:../dom", | ||
| "@wordpress/editor": "14.24.0", |
There was a problem hiding this comment.
The editor package cannot be a dependency for block-library. Only packages that depend on it are edit-site and edit-post.
Mamaduka
left a comment
There was a problem hiding this comment.
I believe something similar was resolved a couple of releases ago. The fix should be more general to the upload handler, instead of the Image block.
Core has more blocks that can upload and use images.
|
Thanks for the review @Mamaduka, ill look for the blocks that have the media library handling and generalize this feature. |
|
Thanks, @Vrishabhsk! |
|
@Vrishabhsk, let's close this PR, since you're planning to explore an alternative solution. |
What?
Why?
How?
uploadedTomediaparametersaved / publishedthe image will be attached to the post where its used.resetoption in the core/image block is selected or the block is removed, the image is detached from the post.attachment/detachmentprocess works via theWP REST APIforattachmentsTesting Instructions
imageviamedia libraryoption.media library.Testing Instructions for Keyboard
Screenshots or screencast
new-feature.mp4