[Categories Block]: Add layout & blockGap support#70254
Open
Mayank-Tripathi32 wants to merge 2 commits intoWordPress:trunkfrom
Open
[Categories Block]: Add layout & blockGap support#70254Mayank-Tripathi32 wants to merge 2 commits intoWordPress:trunkfrom
Mayank-Tripathi32 wants to merge 2 commits intoWordPress:trunkfrom
Conversation
- Added support for block gap in spacing options. - Updated rendering logic to handle term links with separators more efficiently. - Adjusted styles for prefix and suffix alignment in the block. Needed to update to ensure original styling behaviour.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Attempt to resolve #53187 partially
Adds gap control support to the Post Terms block and improves the HTML structure by wrapping each term and separator in individual spans.
Why?
The Post Terms block, like other list-based blocks, lacks gap control functionality, making it difficult for users to control spacing between terms. Additionally, the current HTML structure makes it challenging to apply consistent styling to individual terms and their separators.
How?
Enhanced HTML Structure: Modified both the JavaScript (edit.js) and PHP (index.php) rendering to wrap each term and its separator within individual
<span>elements, providing better semantic structure and styling control.Gap Control Integration: Leveraged the existing gap control infrastructure by:
__experimentalGetGapCSSValueto process gap values (required for editor as gap values are not added)Consistent Rendering: Ensured both editor and frontend rendering produce near identical HTML structure for consistent styling and behavior.
Testing Instructions
Testing Instructions for Keyboard
Screenshots
Updated
Previous