Remove the semicolons from the JSON examples#37129
Merged
aristath merged 1 commit intoWordPress:trunkfrom Dec 6, 2021
Merged
Conversation
I was working through the "Supports" documentation and realised there are some semicolons in the JSON examples. It's best if we remove these so if people are copy and pasting anything into their JSON files it'll work as expected and they don't need to remove the semicolons manually to get webpack to build assets successfully.
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @BronsonQuick! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
aristath
approved these changes
Dec 6, 2021
Member
|
Thank you for the fix @BronsonQuick! The failing tests are not related to this PR so I'll go ahead and merge it since it's a simple docs change 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I was working through the "Supports" documentation and realised there are some semicolons in the JSON examples. It's best if we remove these so if people are copy and pasting anything into their JSON files it'll work as expected and they don't need to remove the semicolons manually to get webpack to build assets successfully.
How has this been tested?
I've copied and pasted these into my
block.jsonfile and webpack has compiled them successfully.I was running Chassis locally with
npm run startso that webpack would build my assets.Screenshots
Types of changes
This simply updates the documentation in the Developer Handbook for the "Supports" section in the Block API Reference section.
Checklist:
*.native.jsfiles for terms that need renaming or removal).